Add PlutusV3 CostModel to UpgradeConwayPParams#4252
Merged
Conversation
aniketd
commented
Apr 10, 2024
teodanciu
reviewed
Apr 10, 2024
Contributor
teodanciu
left a comment
teodanciu
left a comment
There was a problem hiding this comment.
I reckon this requires the conway version to become 1.14.0.0.
And the Changelog for both the updated conway version and core 1.11.1.0 to be updated.
lehins
requested changes
Apr 10, 2024
Collaborator
lehins
left a comment
lehins
left a comment
There was a problem hiding this comment.
Couple of things need adjustment, but otherwise looks good.
aniketd
force-pushed
the
aniketd/conway-genesis-plutus3-cost-models
branch
2 times, most recently
from
8f39ad0 to
25219f8
Compare
aniketd
force-pushed
the
aniketd/conway-genesis-plutus3-cost-models
branch
from
25219f8 to
81f11d9
Compare
lehins
requested changes
Apr 12, 2024
Collaborator
lehins
left a comment
lehins
left a comment
There was a problem hiding this comment.
You where able to remove the Default instance. That's good.
Few changes are still necessary
eras/conway/test-suite/src/Test/Cardano/Ledger/Conway/Examples/Consensus.hs
Show resolved
Hide resolved
aniketd
force-pushed
the
aniketd/conway-genesis-plutus3-cost-models
branch
from
81f11d9 to
aaf6707
Compare
teodanciu
reviewed
Apr 15, 2024
teodanciu
reviewed
Apr 15, 2024
teodanciu
reviewed
Apr 15, 2024
lehins
approved these changes
Apr 15, 2024
Collaborator
lehins
left a comment
lehins
left a comment
There was a problem hiding this comment.
Once you address @teodanciu's comments this PR is ready to go.
aniketd
force-pushed
the
aniketd/conway-genesis-plutus3-cost-models
branch
from
aaf6707 to
09b817e
Compare
Use `updateCostModels` to add them to Conway PParams during tranlation/upgrade from Babbage
aniketd
force-pushed
the
aniketd/conway-genesis-plutus3-cost-models
branch
from
09b817e to
c236b69
Compare
Lucsanszky
added a commit
to IntersectMBO/ouroboros-consensus
that referenced
this pull request
Apr 18, 2024
`exampleConwayGenesis` was made monomorphic here: IntersectMBO/cardano-ledger#4252 The `Crypto c` constraint was removed and now it uses `StandardCrypto`.
Lucsanszky
added a commit
to IntersectMBO/ouroboros-consensus
that referenced
this pull request
Apr 18, 2024
`exampleConwayGenesis` was made monomorphic here: IntersectMBO/cardano-ledger#4252 The `Crypto c` constraint was removed and now it uses `StandardCrypto`.
Lucsanszky
added a commit
to IntersectMBO/ouroboros-consensus
that referenced
this pull request
Apr 19, 2024
`exampleConwayGenesis` was made monomorphic here: IntersectMBO/cardano-ledger#4252 The `Crypto c` constraint was removed and now it uses `StandardCrypto`.
Lucsanszky
added a commit
to IntersectMBO/ouroboros-consensus
that referenced
this pull request
Apr 19, 2024
`exampleConwayGenesis` was made monomorphic here: IntersectMBO/cardano-ledger#4252 The `Crypto c` constraint was removed and now it uses `StandardCrypto`.
Lucsanszky
added a commit
to IntersectMBO/ouroboros-consensus
that referenced
this pull request
Apr 23, 2024
`exampleConwayGenesis` was made monomorphic here: IntersectMBO/cardano-ledger#4252 The `Crypto c` constraint was removed and now it uses `StandardCrypto`.
Lucsanszky
added a commit
to IntersectMBO/ouroboros-consensus
that referenced
this pull request
Apr 24, 2024
`exampleConwayGenesis` was made monomorphic here: IntersectMBO/cardano-ledger#4252 The `Crypto c` constraint was removed and now it uses `StandardCrypto`.
Lucsanszky
added a commit
to IntersectMBO/ouroboros-consensus
that referenced
this pull request
Apr 24, 2024
* Update `index-state` and affected `cardano-ledger` version bounds:
`cardano-ledger` requires `plutus-ledger-api ^>=1.26.0`,
hence the `index-state` update
* Use `StandardCrypto` in protocol info tests:
`exampleConwayGenesis` was made monomorphic here:
IntersectMBO/cardano-ledger#4252
The `Crypto c` constraint was removed and now it uses
`StandardCrypto`.
* Add `plutusV3CostModel` to `Conway` genesis file
* Update `SupportsTwoPhaseValidation` instance for `Conway`:
`ConwayUtxowFailure` was fixed to get rid of the possibility
of injecting `UtxoFailure` in two separate ways
(as seen in the code removed by this commit)
Lucsanszky
added a commit
to IntersectMBO/ouroboros-consensus
that referenced
this pull request
Apr 24, 2024
* Update `index-state` and affected `cardano-ledger` version bounds:
`cardano-ledger` requires `plutus-ledger-api ^>=1.26.0`,
hence the `index-state` update
* Use `StandardCrypto` in protocol info tests:
`exampleConwayGenesis` was made monomorphic here:
IntersectMBO/cardano-ledger#4252
The `Crypto c` constraint was removed and now it uses
`StandardCrypto`.
* Add `plutusV3CostModel` to `Conway` genesis file
* Update `SupportsTwoPhaseValidation` instance for `Conway`:
`ConwayUtxowFailure` was fixed to get rid of the possibility
of injecting `UtxoFailure` in two separate ways
(as seen in the code removed by this commit)
Lucsanszky
added a commit
to IntersectMBO/ouroboros-consensus
that referenced
this pull request
Apr 26, 2024
* Update `index-state` and affected `cardano-ledger` version bounds:
`cardano-ledger` requires `plutus-ledger-api ^>=1.26.0`,
hence the `index-state` update
* Use `StandardCrypto` in protocol info tests:
`exampleConwayGenesis` was made monomorphic here:
IntersectMBO/cardano-ledger#4252
The `Crypto c` constraint was removed and now it uses
`StandardCrypto`.
* Add `plutusV3CostModel` to `Conway` genesis file
* Update `SupportsTwoPhaseValidation` instance for `Conway`:
`ConwayUtxowFailure` was fixed to get rid of the possibility
of injecting `UtxoFailure` in two separate ways
(as seen in the code removed by this commit)
Lucsanszky
added a commit
to IntersectMBO/ouroboros-consensus
that referenced
this pull request
Apr 30, 2024
* Update `index-state` and affected `cardano-ledger` version bounds:
`cardano-ledger` requires `plutus-ledger-api ^>=1.26.0`,
hence the `index-state` update
* Use `StandardCrypto` in protocol info tests:
`exampleConwayGenesis` was made monomorphic here:
IntersectMBO/cardano-ledger#4252
The `Crypto c` constraint was removed and now it uses
`StandardCrypto`.
* Add `plutusV3CostModel` to `Conway` genesis file
* Update `SupportsTwoPhaseValidation` instance for `Conway`:
`ConwayUtxowFailure` was fixed to get rid of the possibility
of injecting `UtxoFailure` in two separate ways
(as seen in the code removed by this commit)
Lucsanszky
added a commit
to IntersectMBO/ouroboros-consensus
that referenced
this pull request
May 9, 2024
* Update `index-state` and affected `cardano-ledger` version bounds:
`cardano-ledger` requires `plutus-ledger-api ^>=1.26.0`,
hence the `index-state` update
* Use `StandardCrypto` in protocol info tests:
`exampleConwayGenesis` was made monomorphic here:
IntersectMBO/cardano-ledger#4252
The `Crypto c` constraint was removed and now it uses
`StandardCrypto`.
* Add `plutusV3CostModel` to `Conway` genesis file
* Update `SupportsTwoPhaseValidation` instance for `Conway`:
`ConwayUtxowFailure` was fixed to get rid of the possibility
of injecting `UtxoFailure` in two separate ways
(as seen in the code removed by this commit)
* Utilize new PParams prediction functionality for HFC
* Accept new cbor format for golden tests
Lucsanszky
added a commit
to IntersectMBO/ouroboros-consensus
that referenced
this pull request
May 9, 2024
* Update `index-state` and affected `cardano-ledger` version bounds:
`cardano-ledger` requires `plutus-ledger-api ^>=1.26.0`,
hence the `index-state` update
* Use `StandardCrypto` in protocol info tests:
`exampleConwayGenesis` was made monomorphic here:
IntersectMBO/cardano-ledger#4252
The `Crypto c` constraint was removed and now it uses
`StandardCrypto`.
* Add `plutusV3CostModel` to `Conway` genesis file
* Update `SupportsTwoPhaseValidation` instance for `Conway`:
`ConwayUtxowFailure` was fixed to get rid of the possibility
of injecting `UtxoFailure` in two separate ways
(as seen in the code removed by this commit)
amesgen
pushed a commit
to IntersectMBO/ouroboros-consensus
that referenced
this pull request
May 13, 2024
* Update `index-state` and affected `cardano-ledger` version bounds:
`cardano-ledger` requires `plutus-ledger-api ^>=1.26.0`,
hence the `index-state` update
* Use `StandardCrypto` in protocol info tests:
`exampleConwayGenesis` was made monomorphic here:
IntersectMBO/cardano-ledger#4252
The `Crypto c` constraint was removed and now it uses
`StandardCrypto`.
* Add `plutusV3CostModel` to `Conway` genesis file
* Update `SupportsTwoPhaseValidation` instance for `Conway`:
`ConwayUtxowFailure` was fixed to get rid of the possibility
of injecting `UtxoFailure` in two separate ways
(as seen in the code removed by this commit)
disassembler
pushed a commit
to IntersectMBO/ouroboros-consensus
that referenced
this pull request
May 13, 2024
* Update `index-state` and affected `cardano-ledger` version bounds:
`cardano-ledger` requires `plutus-ledger-api ^>=1.26.0`,
hence the `index-state` update
* Use `StandardCrypto` in protocol info tests:
`exampleConwayGenesis` was made monomorphic here:
IntersectMBO/cardano-ledger#4252
The `Crypto c` constraint was removed and now it uses
`StandardCrypto`.
* Add `plutusV3CostModel` to `Conway` genesis file
* Update `SupportsTwoPhaseValidation` instance for `Conway`:
`ConwayUtxowFailure` was fixed to get rid of the possibility
of injecting `UtxoFailure` in two separate ways
(as seen in the code removed by this commit)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Resolves #4224
Checklist
.cabalandCHANGELOG.mdfiles according to theversioning process.
.cabalfiles for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)CHANGELOG.mdfor the affected packages. New section is never added with the code changes. (See RELEASING.md)fourmolu(usescripts/fourmolize.sh)scripts/cabal-format.sh)hie.yamlhas been updated (usescripts/gen-hie.sh)